feat(polyline): support drawMode: lines #1098
Open
+197
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
Polyline
supports only consecutive line segments, e.g.[[100, 10], [200, 20], [300, 33]]
means lines from[100, 10]
to[200, 20]
and[200, 20]
to[300, 33]
. But if we want to draw non-consecutive lines like[100, 10]
to[200, 20]
and[400, 40]
to[300, 33]
, we can only use two polylines, which is both more tedious to write and less efficient.In this PR, I propose a new interface
drawMode: 'lineStrip' | 'lines'
forPolyline
. Its default value is'lineStrip'
, which ensures compatibility with the old API.