Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

实现订单模块 #49

Merged
merged 7 commits into from
Mar 26, 2024
Merged

实现订单模块 #49

merged 7 commits into from
Mar 26, 2024

Conversation

longyue0521
Copy link
Collaborator

@longyue0521 longyue0521 commented Mar 24, 2024

  • 基本实现订单模块所有接口
  • 测试全部接口
    • 用定时任务取消订单
    • 消费消息完成订单
    • 其他测试

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 58.80862% with 325 lines in your changes are missing coverage. Please review.

Project coverage is 64.65%. Comparing base (978116c) to head (30e3f0f).
Report is 41 commits behind head on main.

Files Patch % Lines
internal/credit/internal/repository/dao/credit.go 0.00% 80 Missing ⚠️
internal/order/internal/consumer/consumer.go 0.00% 52 Missing ⚠️
internal/order/internal/web/handler.go 88.68% 21 Missing and 10 partials ⚠️
...nal/order/internal/job/close_expired_orders_job.go 0.00% 25 Missing ⚠️
internal/order/internal/repository/repository.go 76.19% 20 Missing and 5 partials ⚠️
internal/job/cron_job_builder.go 0.00% 24 Missing ⚠️
ioc/mq.go 0.00% 23 Missing ⚠️
internal/payment/internal/service/service.go 0.00% 15 Missing ⚠️
internal/order/wire_gen.go 48.14% 14 Missing ⚠️
ioc/job.go 0.00% 7 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #49       +/-   ##
===========================================
- Coverage   90.95%   64.65%   -26.31%     
===========================================
  Files           7       81       +74     
  Lines         365     2637     +2272     
===========================================
+ Hits          332     1705     +1373     
- Misses         24      855      +831     
- Partials        9       77       +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@longyue0521 longyue0521 changed the title [WIP] 实现订单模块 实现订单模块 Mar 26, 2024
@longyue0521
Copy link
Collaborator Author

因定时任务和监听消息队列的代码摆放位置不明, “订单超时自动取消”, “消费支付成功消息, 更新订单状态为已完成”这个两个接口是以API形式实现的, 后续明确定时任务, 及消费事件的代码位置后+wire集成后, 可以很容易的重构. 但要去掉这两个接口的API注册代码、API实现代码 及API对应的测试代码

@longyue0521 longyue0521 merged commit acad751 into ecodeclub:main Mar 26, 2024
3 of 5 checks passed
@longyue0521 longyue0521 deleted the feat_order branch April 6, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant