Simplify repository assembling and reference filtering #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of providing inclusion and exclusion patterns, just provide exclusions, but add a simple way to negate a pattern.
HannesWell
force-pushed
the
simplifyRepoRefFiltering
branch
from
0bda483 to
fa82200
Compare
HannesWell
changed the title
HannesWell
changed the title
HannesWell
added
the
backport-to-tycho-4.0.x
This was referenced Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the simplification parts of #2744.
These are code simplifications and a simplification in the logic of how to specify the filters.
Instead of providing inclusion and exclusion patterns, just use exclusions, but add a simple way to negate a pattern.
A negated exclusion is effectively an inclusion but it should be more clear how inclusion and exclusions work together, as the current definition can be potentially confusing: #2744 (comment)