[win32] fix endless loop with fixed text metrics #1682
Conversation
Test Results 382 files ±0 382 suites ±0 7m 27s ⏱️ -18s For more details on these failures, see this check. Results for commit b1816c7. ± Comparison against base commit 62ad8d9. ♻️ This comment has been updated with latest results. |
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/TextLayout.java
Outdated
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
fix-text-layout-with-fixed-heights
branch
2 times, most recently
from
cfb9510 to
62c800d
Compare
fedejeanne
force-pushed
the
fix-text-layout-with-fixed-heights
branch
from
62c800d to
b6bf03b
Compare
|
I can't understand the errors. I created an issue for it: #1683 The rest seems to be fine but I would like to merge only after all tests ran, hopefully today. Fingers crossed 🤞 |
This commit fixes a regression that ignored bigger fixed font metrics in TextLayout in one scenario that led to an endloop recalculation loop. Fixes eclipse-platform#1610
fedejeanne
force-pushed
the
fix-text-layout-with-fixed-heights
branch
from
b6bf03b to
b1816c7
Compare
|
Ah, so close.... java.lang.Error: SWT Resource was not properly disposed
at org.eclipse.swt.graphics.Resource.initNonDisposeTracking(Resource.java:184)
at org.eclipse.swt.graphics.Resource.<init>(Resource.java:114)
at org.eclipse.swt.graphics.GC.<init>(GC.java:260)
at org.eclipse.swt.graphics.GC.<init>(GC.java:228)
at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_custom_StyledText.test_bug1610_fixedLineHeightWithChangingToSmallerFont_noException(Test_org_eclipse_swt_custom_StyledText.java:5945)
...@akoch-yatta there seems to be a leak in the test so I removed it from this PR and added another one for the test. We can merge that one later --> #1687 |
Damn, yes, forget to clean up at the end of the test. I will create a new PR for that test tomorrow |
This commit fixes a regression that ignored bigger fixed font metrics in TextLayout in one scenario that led to an endloop recalculation loop.
Fixes #1610