Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Java 17 as default instead of Java 1.8 in the #762

Closed
wants to merge 1 commit into from

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Sep 22, 2023

org.eclipse.pde.ui.templates.tests

As we require Java 17 in the latest release, seems reasonable to set this also as default for the tests.

@github-actions
Copy link

github-actions bot commented Sep 22, 2023

Test Results

     270 files  ±0       270 suites  ±0   46m 47s ⏱️ + 2m 26s
  3 329 tests ±0    3 299 ✔️ ±0  30 💤 ±0  0 ±0 
10 284 runs  ±0  10 194 ✔️ ±0  90 💤 ±0  0 ±0 

Results for commit 254770d. ± Comparison against base commit d7a9363.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Member

As we require Java 17 in the latest release, seems reasonable to set this also as default for the tests.

But users might target older releases that don't require Java-17. I think this should be more dynamic.
What do you think about using the version of the workspace's default JVM (obtained from
JavaRuntime.getDefaultVMInstall() casted to IVMInstall2, then you can call getJavaVersion())?
This would also avoid the need to update that value later if a more recent release than 17 is used.

@akurtakov
Copy link
Member

What is the status of this one?

org.eclipse.pde.ui.templates.tests

As we require Java 17 in the latest release, seems reasonable to set
this also as default for the tests.
@akurtakov akurtakov force-pushed the template-tests-small-update branch from aab58ad to 254770d Compare December 11, 2023 11:03
@vogella
Copy link
Contributor Author

vogella commented Dec 11, 2023

Currently not working on this one.

@vogella vogella closed this Dec 11, 2023
@vogella vogella deleted the template-tests-small-update branch December 19, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants