Code Cleanup: Java 16 instanceof pattern matching in pde.ui #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are removed comments which shouldn't happen . Please check and fix. |
Test Results 267 files - 6 267 suites - 6 53m 32s ⏱️ - 20m 46s For more details on these failures, see this check. Results for commit 5e9c236. ± Comparison against base commit a19c8ed. ♻️ This comment has been updated with latest results. |
akurtakov
force-pushed
the
pde_ui_cleanup
branch
from
5c0dd55 to
d5045c5
Compare
|
Please rebase on top of master as there are conflicts. |
|
There is conflict. Would you please fix it and rebase on top of master. |
Hi @akurtakov , |
alshamams
force-pushed
the
pde_ui_cleanup
branch
from
d5045c5 to
5e9c236
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit tries to implement a code cleanup in pattern matching using instanceof operator according to Java 16 guidelines, making the code more concise.
The change has been applied in org.eclipse.pde.ui project.
Kindly review @akurtakov @iloveeclipse @vik-chand @gireeshpunathil and do let me know in case of any edits.