Assert at the end of the Register Allocation Phase that the numbers of Start and End internal control flow labels were equal #7597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the number of Start internal control flow labels does not equal the number of End internal control flow labels, the result might be subtle intermittent problems related to register allocation. This change adds an assertion that, at the completion of the Register Allocation Phase, the register allocator must not indicate that it's still nested within a region of internal control flow nor popped out of too many regions of internal control flow. Signed-off-by: Henry Zongaro <[email protected]>
|
I have started running testing on this change with a downstream project to determine whether it uncovers any cases where Start and End internal control flow labels are mismatched. Those instances ought to be corrected before this change is merged to avoid breaking downstream projects. It could also be that there are cases where it really is permissible to have more or fewer Start internal control flow labels than End labels. If that is the case, this pull request might need to be revised or abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the number of Start internal control flow labels does not equal the number of End internal control flow labels, the result might be subtle intermittent problems related to register allocation.
This change adds an assertion that, at the completion of the Register Allocation Phase, the register allocator must not indicate that it's still nested within a region of internal control flow nor popped out of too many regions of internal control flow.