Check if mul can overflow during BNDCHK simplification #7575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For BNDCHK nodes where the first child is a constant and the second child is a multiplication operation, with the multiplier child being a constant, it was getting simplified such that the bound value was being divided by the multiplier. While this is a valid simplification that eliminates the multiplication operation, it would only be valid if we could guarantee that the multiplication was not going to overflow. This change ensures that this simplification is performed only for mul operation nodes that have been marked as cannotOverflow. Signed-off-by: Nazim Bhuiyan <[email protected]>
|
@hzongaro requesting review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For BNDCHK nodes where the first child is a constant and the second child is a multiplication operation, with the multiplier child being a constant, it was getting simplified such that the bound value was being divided by the multiplier. While this is a valid simplification that eliminates the multiplication operation, it would only be valid if we could guarantee that the multiplication was not going to overflow. This change ensures that this simplification is performed only for mul operation nodes that have been marked as cannotOverflow.
Issue: eclipse-openj9/openj9#19139