Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete AlignTLHAlloc TR::Node flag #7326

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −28
Draft

Remove obsolete AlignTLHAlloc TR::Node flag #7326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions compiler/il/OMRNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7522,26 +7522,6 @@ OMR::Node::setIsBigDecimalLoad()
_flags.set(bigDecimal_load);
}



bool
OMR::Node::shouldAlignTLHAlloc()
{
TR_ASSERT(self()->getOpCodeValue() == TR::New, "Opcode value must be TR::New");
return _flags.testAny(alignTLHAlloc);
}

void
OMR::Node::setAlignTLHAlloc(bool v)
{
TR::Compilation * c = TR::comp();
TR_ASSERT(self()->getOpCodeValue() == TR::New, "Opcode value must be TR::New");
if (performNodeTransformation2(c, "O^O NODE FLAGS: Setting align on TLH flag on node %p to %d\n", self(), v))
_flags.set(alignTLHAlloc, v);
}



bool
OMR::Node::isCopyToNewVirtualRegister()
{
Expand Down
9 changes: 1 addition & 8 deletions compiler/il/OMRNode.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,10 +1510,6 @@ class OMR_EXTENSIBLE Node
bool isLoadAndTest() { return _flags.testAny(loadAndTest); }
void setIsLoadAndTest(bool v) { _flags.set(loadAndTest, v); }

// Flag for TR::New
bool shouldAlignTLHAlloc();
void setAlignTLHAlloc(bool v);

// Flag used by TR_PassThrough
bool isCopyToNewVirtualRegister();
void setCopyToNewVirtualRegister(bool v = true);
Expand Down Expand Up @@ -2021,10 +2017,7 @@ class OMR_EXTENSIBLE Node
// Flag used by iload, iiload, lload, ilload, aload, iaload
loadAndTest = 0x00008000,

// Flag used by TR::New when the codegen supports
// alignment on the TLH when allocating the object
//
alignTLHAlloc = 0x00002000,
// Available = 0x00002000, // AVAILABLE FOR USE

// Flag used by TR_PassThrough
copyToNewVirtualRegister = 0x00001000,
Expand Down
Loading