Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message if artifact can not be downloaded from any repository #502

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Apr 23, 2024

There are rare cases where one gets a message that an artifact can not be downloaded from any repository, this has two pitfalls:

  1. You don't get an idea what repositories are actually contacted 2) Its hard to find out who actually requires this artifact

This now enhances an IArtifactRequest by a method to set a "context iu" why this artifact is requested. If the information is given, it searches through the available IUs and gives additional information why it is required and what repositories are queried.

@laeubi laeubi requested a review from merks April 23, 2024 11:34
Copy link

github-actions bot commented Apr 23, 2024

Test Results

    6 files  ±0      6 suites  ±0   19m 41s ⏱️ -5s
2 184 tests ±0  2 180 ✅ ±0  4 💤 ±0  0 ❌ ±0 
4 426 runs  ±0  4 419 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit 05559a3. ± Comparison against base commit e82bbdf.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the improve_message_if_missing branch from 4e39ead to 229d269 Compare April 23, 2024 14:38
There are rare cases where one gets a message that an artifact can not
be downloaded from any repository, this has two pitfalls:

1) You don't get an idea what repositories are actually contacted
2) Its hard to find out who actually requires this artifact

This now enhances an IArtifactRequest by a method to set a "context iu"
why this artifact is requested. If the information is given, it searches
through the available IUs and gives additional information why it is
required and what repositories are queried.
@laeubi laeubi force-pushed the improve_message_if_missing branch from 229d269 to 05559a3 Compare April 24, 2024 04:48
@laeubi
Copy link
Member Author

laeubi commented Apr 24, 2024

@merks I made this now more "local" change.

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an observation. The IU's id and version of the IU that requires the artifact typically provides identical information, as the artifact key and version. Providing the first level of incoming requirements might beg for the next level of IU dependencies.

@laeubi laeubi merged commit 8bcba76 into eclipse-equinox:master Apr 24, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants