feat: federated catalog node resolver sample #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested changes
Dec 17, 2024
...et-node-resolver/src/main/java/org/eclipse/edc/sample/extension/fc/CatalogNodeDirectory.java
Outdated
Show resolved
Hide resolved
...esolver/src/main/java/org/eclipse/edc/sample/extension/fc/CatalogNodeDirectoryExtension.java
Outdated
Show resolved
Hide resolved
...esolver/src/main/java/org/eclipse/edc/sample/extension/fc/CatalogNodeDirectoryExtension.java
Outdated
Show resolved
Hide resolved
system-tests/build.gradle.kts
Outdated
Comment on lines
21
to
24
| tasks.test { | ||
| workingDir = rootProject.projectDir | ||
| } | ||
|
|
There was a problem hiding this comment.
I have changed the implementation a little bit and as part of that I have removed this code block.
|
|
||
| @EndToEndTest | ||
| class Policy01BasicTest { | ||
|
|
||
| private static final Duration TIMEOUT = Duration.ofSeconds(90); |
There was a problem hiding this comment.
is this used? looks a bit out of scope
There was a problem hiding this comment.
Previously the Policy01BasicTest was using the TIMEOUT defined in TransferUtil which is 30 seconds. As the test was failing pipeline, the TIMEOUT has been defined locally with a increased time duration.
…typeManager in Extension file
…DirectoryExtension.java
ndr-brt
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds a new sample:
fc-03-static-node-resolverin thefederated-catalogsample module. It includes demonstration of a catalog node resolver that implements theTargetNodeDirectory, and resolves the target nodes to crawl from a static participants file.Why it does that
To illustrate how we can implement
TargetNodeDirectoryto resolve the target nodes in a dataspace. And then how this can be used with both standalone and embedded versions of federated catalog.Further notes
Projects and libraries have been added in settings.gradle.kts.
In system-tests->build.gradle.kts working directory has been set to project directory.
Linked Issue(s)
Contributes to #296
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.