Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QuarkusDevFileAPI and LombokDevFileAPI tests #23295

Merged
merged 11 commits into from
Jan 5, 2025
Merged

Add QuarkusDevFileAPI and LombokDevFileAPI tests #23295

merged 11 commits into from
Jan 5, 2025

Conversation

dmytro-ndp
Copy link
Contributor

@dmytro-ndp dmytro-ndp commented Dec 20, 2024

What does this PR do?

  1. Add QuarkusDevFileAPI test.
  2. Add LombokDevFileAPI test.
  3. Refactor functionality for Dev Workspace Template removal in E2E TypeScript API tests.
  4. Fix address to the product.json repo in Documentation.spec.ts test.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7875,
https://issues.redhat.com/browse/CRW-7876

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts Dismissed Show dismissed Hide dismissed
tests/e2e/utils/KubernetesCommandLineToolsExecutor.ts Dismissed Show dismissed Hide dismissed
Signed-off-by: Dmytro Nochevnov <[email protected]>
Signed-off-by: Dmytro Nochevnov <[email protected]>
@dmytro-ndp dmytro-ndp marked this pull request as ready for review January 3, 2025 16:36
@dmytro-ndp dmytro-ndp requested review from artaleks9 and removed request for musienko-maxim January 3, 2025 16:36
@dmytro-ndp dmytro-ndp changed the title [DRAFT] Add QuarkusDevFileAPI test Add QuarkusDevFileAPI test Jan 3, 2025
@dmytro-ndp dmytro-ndp changed the title Add QuarkusDevFileAPI test Add QuarkusDevFileAPI and LombokDevFileAPI tests Jan 3, 2025
@artaleks9
Copy link
Contributor

Looks good to merge, good job !

@dmytro-ndp
Copy link
Contributor Author

dmytro-ndp commented Jan 5, 2025

For the record: "Empty Workspace test suite on minikube" PR check has failed because of problem with opening Empty Workspace in Eclipse Che:
screenshot-Wait_workspace_readiness

@dmytro-ndp dmytro-ndp merged commit 4c060ae into main Jan 5, 2025
4 of 5 checks passed
@dmytro-ndp dmytro-ndp deleted the CRW-7875 branch January 5, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants