feat: add support to use rcodesign for macosx signing service #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
staging service is deployed and a Jenkins job is running: https://ci.eclipse.org/cbi/job/webservices-monitoring/job/macos-signing-staging/ |
|
rcodesign 0.28.0 has been released including the necessary fix: https://github.com/indygreg/apple-platform-rs/releases/tag/apple-codesign%2F0.28.0 the fix is not mentioned in the release notes but I checked the files at the release commit and the change is present, will update the PR and test. Its in the changelog of the sub-crate where it was fixed: https://github.com/indygreg/apple-platform-rs/blob/main/apple-xar/CHANGELOG.md#0190 |
|
updated the staging service to use the latest version of rcodesign. Will ask projects to use the staging service for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #380 and #461.
The implementation itself is finished and working in local testing, however the deployment needs to be finalized.
On top of that signing needs to be checked with various file types and deep signing needs to be verified as well.
The used rcodesign version (latest release) has a bug handling pkg files, created a PR for the project to fix that.