Skip to content
This repository has been archived by the owner on Feb 21, 2019. It is now read-only.

Removed eclipse configuration files #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fjodorver
Copy link

Here I removed eclipse configuration files in order to simplify commit stage

Signed-off-by: Fjodor Vershinin <[email protected]>
@martinlippert
Copy link
Contributor

Not totally sure that this is a good idea. If someone checks out the projects from Git and want to import it into a workspace, what should they do? Right now, they can just "Import as Existing Projects", but if we remove the Eclipse config files, this is no longer possible.

@fjodorver
Copy link
Author

My arguments would be:

  • I think it makes commit process much easier, because then we don't need to remove changed eclipse files from git staging area.
  • This is common approach, do not have IDE dependent files in git repository, because people can use different IDEs, for example Intellij IDEA or Eclipse. However, it would be funny, if Eclipse developers use IDEA :)
  • Some eclipse settings and project entries are dev-environment dependent, for example they can contain absolute paths. So, if somebody accidentally commits such files, he can break other developer's environment.
  • This is maven project, so it can be easily imported as maven one. Eclipse automatically generates all .project, .classpath and .settings files.

@martinlippert
Copy link
Contributor

I see your points and agree for the projects that are not Eclipse Plugin projects. Even though they have a pom.xml file and are build using Maven and Tycho, they should keep the metadata in order to get them imported nicely into Eclipse (and it doesn't make much sense to work on them using a different tool, since they are plugins for Eclipse only).

For the other projects, I totally agree to your points. Would you change the PR in order to remove the above mentioned metadata only? That would be great.

@fjodorver
Copy link
Author

So, your proposal is to remove some entries from files, not whole files?

@martinlippert
Copy link
Contributor

No. My proposal was to remove the metadata files for those projects that are regular Maven projects and to not remove those metadata files for those projects that are Eclipse plug-in projects. Sorry for being too vage in my comment above... ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants