Set client state to CS_CONNECTED during UDP downloads #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set client state to CS_CONNECTED instead of CS_PRIMED during UDP downloads. Avoids server-to-client commands from accumulating without being sent, leading to unnecessary commands being sent when the download finishes or possibly the client being dropped with "server command overflow" error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the server leaves clients set to CS_PRIMED during UDP downloads. This means that reliable commands from server to client can be generated, but not sent while the download is in progress. This can lead to a surge of commands being sent when the download finishes, or if enough commands are generated, the client being dropped with a "server command overflow" error.
This fix sets the client to CS_CONNECTED during downloads, which prevents unnecessary commands from being issued until the download completes and the new gamestate is sent.
Downloading clients were already set to CS_CONNECTED if a map change occurred during the download, but with this change it is set for all downloads.