Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing curl dependency #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthieujung
Copy link

Here is an update of the code in order to remove curl dependency. So functions can be run even with no internet access. Code was also rearranged to easily create a conda package. Do do that, at least a tag is needed. I don't know if the tag that I have created in my fork will be pulled. If not, remember to create a tag named with the corresponding version number of the package.

@grst
Copy link

grst commented Jul 4, 2022

This would fix omnideconv/immunedeconv#91

Copy link
Contributor

@FPetitprez FPetitprez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original intent of relying on curl was to allow signature updating without requiring users to update the package, but signatures are unlikely to change now, so they can be integrated to the package itself as this commit suggests.

@grst
Copy link

grst commented Jul 4, 2022

btw, it would also be great if you could make a versioned release once this is merged. Like that we can update the bioconda recipe.

@matthieujung
Copy link
Author

The original intent of relying on curl was to allow signature updating without requiring users to update the package, but signatures are unlikely to change now, so they can be integrated to the package itself as this commit suggests.

I'm sorry, I thought these data were final. However, I don't think this is the right way to do that, because the link indicated in the code referes to the latest version of the package and not to a specific version. In this case, a version installed at a user could lead to two different results with two executions at different point time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants