Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): handle context change just after property being initialized #4509

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

weareoutman
Copy link
Member

依赖检查

组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。

请勾选以下两组选项其中之一:

  • 本次 MR 没有使用上游组件(例如框架、后台组件等)的较新版本提供的特性。

或者:

  • 本次 MR 使用了上游组件(例如框架、后台组件等)的较新版本提供的特性。
  • 在对应的文件中更新了该上游组件的依赖版本(或确认了当前声明的依赖版本已包含本次 MR 使用的新特性)。

提交信息检查

Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。

破坏性变更是针对于下游使用者而言,可以通过本次改动对下游使用者的影响来识别变更类型:

  • 下游使用者不做任何改动,仍可以正常工作时,那么它属于普通变更。
  • 反之,下游使用者不做改动就无法正常工作时,那么它属于破坏性变更。

例如,构件修改了一个属性名,小产品 Storyboard 中需要使用新属性名才能工作,那么它就是破坏性变更。
又例如,构件还没有任何下游使用者,那么它的任何变更都是普通变更。

破坏性变更:

  • ⚠️ 本次 MR 包含破坏性变更的提交,请继续确认以下所有选项:
  • 没有更好的兼容方案,必须做破坏性变更。
  • 使用了 feat 作为提交类型。
  • 标注了 BREAKING CHANGE: 你的变更说明
  • 同时更新了本仓库中所有下游使用者的调用。
  • 同时更新了本仓库中所有下游使用者对该子包的依赖为即将发布的 major 版本。
  • 同时为其它仓库的 Migrating 做好了准备,例如文档或批量改动的方法。
  • 手动验证过破坏性变更在 Migrate 后可以正常工作。
  • 破坏性变更所在的提交没有意外携带其它子包的改动。

新特性:

  • 本次 MR 包含新特性的提交,且该提交不带有破坏性变更,并使用了 feat 作为提交类型。
  • 给新特性添加了单元测试。
  • 手动验证过新特性可以正常工作。

问题修复:

  • 本次 MR 包含问题修复的提交,且该提交不带有新特性或破坏性变更,并使用了 fix 作为提交类型。
  • 给问题修复添加了单元测试。
  • 手动验证过问题修复得到解决。

杂项工作:

即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:

  • 本次 MR 包含杂项工作的提交,且该提交不带有问题修复、新特性或破坏性变更,并使用了 chore, docs, test 等作为提交类型。

Copy link

cypress bot commented Oct 11, 2024

next-core    Run #10644

Run Properties:  status check passed Passed #10644  •  git commit bef1dabb73 ℹ️: Merge d1b99ff3cd0503f2c844eeef8310dc5afaa8bf1d into 4b32254eaec3f6a76db85e0a7756...
Project next-core
Run status status check passed Passed #10644
Run duration 00m 24s
Commit git commit bef1dabb73 ℹ️: Merge d1b99ff3cd0503f2c844eeef8310dc5afaa8bf1d into 4b32254eaec3f6a76db85e0a7756...
Committer Shenwei Wang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 16

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.20%. Comparing base (4b32254) to head (d1b99ff).
Report is 3 commits behind head on v3.

Files with missing lines Patch % Lines
packages/runtime/src/internal/Renderer.ts 89.47% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v3    #4509      +/-   ##
==========================================
+ Coverage   95.18%   95.20%   +0.01%     
==========================================
  Files         204      204              
  Lines        8835     8846      +11     
  Branches     1678     1679       +1     
==========================================
+ Hits         8410     8422      +12     
  Misses        319      319              
+ Partials      106      105       -1     
Files with missing lines Coverage Δ
...me/src/internal/compute/listenOnTrackingContext.ts 100.00% <100.00%> (ø)
packages/runtime/src/internal/Renderer.ts 94.23% <89.47%> (+0.28%) ⬆️

@weareoutman weareoutman force-pushed the steve/v3-track-after-initial branch from 084bee1 to d1b99ff Compare October 11, 2024 03:34
@weareoutman
Copy link
Member Author

This pull request includes several changes aimed at enhancing the rendering process, improving test coverage, and updating configuration files. The most important changes are grouped by theme below.

Enhancements to Rendering Process:

Test Coverage Improvements:

Configuration Updates:

Code Quality Enhancements:

These changes collectively enhance the rendering process, improve test coverage, and update configurations to ensure a more robust and maintainable codebase.

@weareoutman weareoutman requested a review from willc001 October 11, 2024 03:47
@willc001 willc001 merged commit eceb450 into v3 Oct 11, 2024
5 of 6 checks passed
@willc001 willc001 deleted the steve/v3-track-after-initial branch October 11, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants