fix(): fix permissions check within dynamic menu

easyops-cn · Oct 8, 2023 · d7a0e71 · d7a0e71
1 parent 47ef7fa
commit d7a0e71
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/brick-kit/src/internal/menu.spec.ts b/packages/brick-kit/src/internal/menu.spec.ts
@@ -366,7 +366,7 @@ const mockMenuList: any[] = [
     title: "Menu i",
     dynamicItems: true,
     itemsResolve: {
-      args: ["<% PATH.objectId %>"],
+      args: ["<% PATH.objectId %>", "<% PERMISSIONS.check('x:y') %>"],
       useProvider: "my.fake-provider",
     },
     items: [
@@ -472,6 +472,8 @@ describe("fetchMenuById", () => {
   it("menu should not cache cache", async () => {
     await fetchMenuById("menu-i", fakeKernel);
     expect(InstanceApi_postSearch).toHaveBeenCalledTimes(1);
+    expect(validatePermissions).toBeCalledTimes(1);
+    expect(validatePermissions).toBeCalledWith(["x:y"]);
     await fetchMenuById("menu-i", fakeKernel);
     expect(InstanceApi_postSearch).toHaveBeenCalledTimes(2);
   });

diff --git a/packages/brick-kit/src/internal/menu.ts b/packages/brick-kit/src/internal/menu.ts
@@ -302,6 +302,10 @@ async function loadDynamicMenuItems(
         };
       }
     }
+
+    const usedActions = scanPermissionActionsInAny(menu.itemsResolve);
+    await validatePermissions(usedActions);
+
     await _internalApiGetResolver().resolveOne(
       "reference",
       {