fix(): 如果小产品自定义了title无论什么情况都显示自定义title

easyops-cn · Jul 23, 2024 · 9924e46 · 9924e46
1 parent d58363d
commit 9924e46
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/runtime/src/internal/Runtime.spec.ts b/packages/runtime/src/internal/Runtime.spec.ts
@@ -1412,7 +1412,7 @@ describe("Runtime", () => {
     getRuntime().applyPageTitle("Hello");
     expect(document.title).toBe("Hi there");
     getRuntime().applyPageTitle("");
-    expect(document.title).toBe("DevOps 管理专家");
+    expect(document.title).toBe("Hi there");
     expect(finishPageView).toBeCalledTimes(1);
     expect(finishPageView).toBeCalledWith({
       pageTitle: "DevOps 管理专家",

diff --git a/packages/runtime/src/internal/Runtime.ts b/packages/runtime/src/internal/Runtime.ts
@@ -287,10 +287,11 @@ export class Runtime {
 
   applyPageTitle(pageTitle: string): void {
     const baseTitle = this.getBrandSettings().base_title;
-    document.title = pageTitle
-      ? (router?.getRecentApps().currentApp?.localeTitle as string) ||
-        `${pageTitle} - ${baseTitle}`
-      : baseTitle;
+    document.title = (router?.getRecentApps().currentApp?.localeTitle as string)
+      ? (router?.getRecentApps().currentApp?.localeTitle as string)
+      : pageTitle
+        ? `${pageTitle} - ${baseTitle}`
+        : baseTitle;
   }
 
   getNavConfig() {