do not attach PIPE file handle on STDIN of run_shell_cmd unless there are contents for it
#4728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are contents to be passed through it
lexming
force-pushed
the
perl-interact-shell
branch
from
bdfc65e to
a5e0937
Compare
boegel
changed the title
run_shell_cmd unless there are contents for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes easybuilders/easybuild-easyconfigs#22094
We always attach the PIPE file handle to STDIN regardless if there is any input to be passed to the command. This seems to be ok on Python 3.9+, but it is troublesome on Python 3.6 where the resulting shell has as an attached handle without EOF even if nothing is passed to STDIN. So software like perl think that they are inside an interactive shell.