Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate Sys::Info extensions from Perl-bundle-CPAN #22095

Merged
merged 1 commit into from
Dec 23, 2024
Merged

remove duplicate Sys::Info extensions from Perl-bundle-CPAN #22095

merged 1 commit into from
Dec 23, 2024
+7 −42

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Dec 22, 2024

(created using eb --new-pr)

@lexming lexming changed the base branch from develop to 5.0.x December 22, 2024 23:32
@lexming lexming added this to the 5.0 milestone Dec 22, 2024
@lexming lexming force-pushed the 20241223003056_new_pr_Perl-bundle-CPAN5361 branch from 89e88f0 to e8c4913 Compare December 22, 2024 23:45
@lexming lexming force-pushed the 20241223003056_new_pr_Perl-bundle-CPAN5361 branch from e8c4913 to 7a8af07 Compare December 22, 2024 23:46
@lexming
Copy link
Contributor Author

lexming commented Dec 22, 2024

@boegelbot please test @ jsc-zen3
EB_BRANCH=5.0.x

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=22095 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_22095 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5474

Test results coming soon (I hope)...

- notification for comment with ID 2558661879 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/cb0dcfe9c02f13f00be412884d5284b8 for a full test report.

@boegel boegel removed the change label Dec 23, 2024
boegel
boegel approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Dec 23, 2024

Going in, thanks @lexming!

@boegel boegel merged commit b79a9e4 into easybuilders:5.0.x Dec 23, 2024
8 checks passed
@boegel boegel changed the title remove duplicate Sys::Info extensions from Perl-bundle-CPAN remove duplicate Sys::Info extensions from Perl-bundle-CPAN Dec 23, 2024
@lexming lexming deleted the 20241223003056_new_pr_Perl-bundle-CPAN5361 branch December 23, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
code cleanup EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lexming @boegelbot @boegel