Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap 2024a generation of ANTLR to use Java/17 and switch NCO-5.2.9-foss-2024a.eb to use it #22066

Merged

Conversation

branfosj
Copy link
Member

(created using eb --new-pr)

@branfosj branfosj changed the title add ANTLR using Java/17 and switch NCO-5.2.9-foss-2024a.eb to use it swap 2024a generation of ANTLR to use Java/17 and switch NCO-5.2.9-foss-2024a.eb to use it Dec 19, 2024
Copy link

Updated software ANTLR-2.7.7-GCCcore-13.3.0-Java-17.eb

Diff against ANTLR-2.7.7-GCCcore-13.3.0-Java-21.0.2.eb

easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-13.3.0-Java-21.0.2.eb

diff --git a/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-13.3.0-Java-21.0.2.eb b/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-13.3.0-Java-17.eb
index 333a037427..e614536bfb 100644
--- a/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-13.3.0-Java-21.0.2.eb
+++ b/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-13.3.0-Java-17.eb
@@ -22,7 +22,7 @@ checksums = [
 
 builddependencies = [('binutils', '2.42')]
 
-dependencies = [('Java', '21.0.2', '', SYSTEM)]
+dependencies = [('Java', '17', '', SYSTEM)]
 
 configopts = '--disable-examples --disable-csharp --disable-python'
 
Diff against ANTLR-2.7.7-GCCcore-12.3.0-Java-11.eb

easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-12.3.0-Java-11.eb

diff --git a/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-12.3.0-Java-11.eb b/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-13.3.0-Java-17.eb
index 4f76242d89..e614536bfb 100644
--- a/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-12.3.0-Java-11.eb
+++ b/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-13.3.0-Java-17.eb
@@ -10,7 +10,7 @@ description = """ANTLR, ANother Tool for Language Recognition, (formerly PCCTS)
  compilers, and translators from grammatical descriptions containing
  Java, C#, C++, or Python actions."""
 
-toolchain = {'name': 'GCCcore', 'version': '12.3.0'}
+toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 
 source_urls = ['https://www.antlr2.org/download/']
 sources = [SOURCELOWER_TAR_GZ]
@@ -20,9 +20,9 @@ checksums = [
     'd167d3248a03301bc93efcb37d5df959aae6794968e42231af0b0dd26d6a2e66',  # ANTLR-2.7.7_includes.patch
 ]
 
-builddependencies = [('binutils', '2.40')]
+builddependencies = [('binutils', '2.42')]
 
-dependencies = [('Java', '11', '', SYSTEM)]
+dependencies = [('Java', '17', '', SYSTEM)]
 
 configopts = '--disable-examples --disable-csharp --disable-python'
 
Diff against ANTLR-2.7.7-GCCcore-11.3.0-Java-11.eb

easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-11.3.0-Java-11.eb

diff --git a/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-11.3.0-Java-11.eb b/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-13.3.0-Java-17.eb
index 034e0e3956..e614536bfb 100644
--- a/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-11.3.0-Java-11.eb
+++ b/easybuild/easyconfigs/a/ANTLR/ANTLR-2.7.7-GCCcore-13.3.0-Java-17.eb
@@ -10,7 +10,7 @@ description = """ANTLR, ANother Tool for Language Recognition, (formerly PCCTS)
  compilers, and translators from grammatical descriptions containing
  Java, C#, C++, or Python actions."""
 
-toolchain = {'name': 'GCCcore', 'version': '11.3.0'}
+toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 
 source_urls = ['https://www.antlr2.org/download/']
 sources = [SOURCELOWER_TAR_GZ]
@@ -20,9 +20,9 @@ checksums = [
     'd167d3248a03301bc93efcb37d5df959aae6794968e42231af0b0dd26d6a2e66',  # ANTLR-2.7.7_includes.patch
 ]
 
-builddependencies = [('binutils', '2.38')]
+builddependencies = [('binutils', '2.42')]
 
-dependencies = [('Java', '11', '', SYSTEM)]
+dependencies = [('Java', '17', '', SYSTEM)]
 
 configopts = '--disable-examples --disable-csharp --disable-python'
 

@github-actions github-actions bot removed the update label Dec 19, 2024
@branfosj
Copy link
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=22066 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22066 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14892

Test results coming soon (I hope)...

- notification for comment with ID 2554567723 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/bf78d50718411ca8ce1a8f69dda2eb42 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d1cede2a7a5a0096ef250370a1a0e0a8 for a full test report.

@SebastianAchilles SebastianAchilles added this to the release after 4.9.4 milestone Dec 19, 2024
@branfosj
Copy link
Member Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22066 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22066 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5468

Test results coming soon (I hope)...

- notification for comment with ID 2554684976 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/f668324fce53c775353a2ac03a790d30 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
skl-almalinux-95 - Linux AlmaLinux 9.5 (Teal Serval), x86_64, Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (skylake), Python 3.9.19
See https://gist.github.com/SebastianAchilles/bd8c6418afe7d73cc5f3de9f5a893f83 for a full test report.

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @branfosj!

@SebastianAchilles SebastianAchilles merged commit 5b434b5 into easybuilders:develop Dec 19, 2024
10 checks passed
@jfgrimm
Copy link
Member

jfgrimm commented Dec 19, 2024

Test report by @jfgrimm
FAILED
Build succeeded for 26 out of 37 (2 easyconfigs in total)
node009.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/3fe8f283ad49df0c2aeefdc6dc03da0c for a full test report.

@branfosj branfosj deleted the 20241219144023_new_pr_NCO529 branch December 19, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants