Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{devel,lib}[GCCcore/13.3.0] GOTCHA v1.0.7, Check v0.15.2 #21399

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

Thyre
Copy link
Contributor

@Thyre Thyre commented Sep 13, 2024

Add GOTCHA, a library which helps to wrap function calls. This will get relevant for tools like Score-P.
The build itself is straight-forward, but parallel builds need to be disabled due to issues when enabling tests.
This is not a huge problem though, as the library builds quickly (~20 seconds on my machine).

@Thyre
Copy link
Contributor Author

Thyre commented Sep 13, 2024

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
Linux - Linux EndeavourOS UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x NVIDIA NVIDIA GeForce RTX 3070, 560.35.03, Python 3.12.6
See https://gist.github.com/Thyre/b5e50dab0ae8d5fc81430f99ee5c5c1b for a full test report.

@Thyre Thyre force-pushed the 2024a-gotcha-1.0.7 branch from 87bf02b to 9325871 Compare September 13, 2024 10:26
@Thyre
Copy link
Contributor Author

Thyre commented Sep 13, 2024

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
Linux - Linux EndeavourOS UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x NVIDIA NVIDIA GeForce RTX 3070, 560.35.03, Python 3.12.6
See https://gist.github.com/Thyre/518c6f2f7b71ee6cc61a37646a07381e for a full test report.

@Thyre Thyre force-pushed the 2024a-gotcha-1.0.7 branch from 9325871 to b95b111 Compare September 13, 2024 11:13
@smoors smoors added new 2024a issues & PRs related to 2024a common toolchains labels Sep 13, 2024
@smoors
Copy link
Contributor

smoors commented Sep 13, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=21399 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21399 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14268

Test results coming soon (I hope)...

- notification for comment with ID 2349757033 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/590cfb7a9d64621b76e9f817c0353ed1 for a full test report.

@Thyre
Copy link
Contributor Author

Thyre commented Sep 13, 2024

Test report by @boegelbot FAILED Build succeeded for 0 out of 1 (1 easyconfigs in total) cns3 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/boegelbot/590cfb7a9d64621b76e9f817c0353ed1 for a full test report.

Interesting. This looks like linking the downloaded library for the tests failed. Since parallel also causes issues with the tests, disabling the tests might be worth it...

@smoors
Copy link
Contributor

smoors commented Sep 13, 2024

Test report by @smoors
FAILED
Build succeeded for 20 out of 21 (1 easyconfigs in total)
node300.hydra.os - Linux Rocky Linux 8.10, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/smoors/ef7d8cb1b6bfa770d2dba27cc94b3f35 for a full test report.

@Thyre Thyre force-pushed the 2024a-gotcha-1.0.7 branch from b95b111 to 8141a3f Compare September 14, 2024 09:07
@Thyre Thyre force-pushed the 2024a-gotcha-1.0.7 branch from 8141a3f to 5fefc6d Compare September 14, 2024 09:08
@Thyre
Copy link
Contributor Author

Thyre commented Sep 14, 2024

Test report by @Thyre
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
Linux - Linux EndeavourOS UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x NVIDIA NVIDIA GeForce RTX 3070, 560.35.03, Python 3.12.6
See https://gist.github.com/Thyre/e9c5d561752c46f52d6eaa14efa05868 for a full test report.

@Thyre
Copy link
Contributor Author

Thyre commented Sep 14, 2024

Switched to Check in EasyBuild (added EasyConfig for GCCcore/13.3.0). This should hopefully solve the issues.

@Thyre Thyre changed the title {devel}{GCCcore/13.3.0} Add GOTCHA v1.0.7 {devel,lib}{GCCcore/13.3.0} Add GOTCHA v1.0.7, Check v0.15.2 Sep 14, 2024
@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
skl-rockylinux-810 - Linux Rocky Linux 8.10, x86_64, Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz (skylake), 1 x NVIDIA NVIDIA RTX A4000, 555.42.06, Python 3.6.8
See https://gist.github.com/SebastianAchilles/a018630e7aaecdec4ea4df9b9fcccefc for a full test report.

@SebastianAchilles
Copy link
Member

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21399 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21399 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4878

Test results coming soon (I hope)...

- notification for comment with ID 2350958780 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/07c511cf05830b5a4fa41410bec4daef for a full test report.

@SebastianAchilles
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=21399 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21399 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14273

Test results coming soon (I hope)...

- notification for comment with ID 2350959862 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/60d1bf9c49379816151db264a456557c for a full test report.

@smoors smoors added the update label Sep 27, 2024
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the release after 4.9.4 milestone Sep 27, 2024
@smoors
Copy link
Contributor

smoors commented Sep 27, 2024

Going in, thanks @Thyre!

@smoors smoors merged commit 2785873 into easybuilders:develop Sep 27, 2024
9 checks passed
@boegel boegel changed the title {devel,lib}{GCCcore/13.3.0} Add GOTCHA v1.0.7, Check v0.15.2 {devel,lib}[GCCcore/13.3.0] GOTCHA v1.0.7, Check v0.15.2 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024a issues & PRs related to 2024a common toolchains new update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants