-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{devel,lib}[GCCcore/13.3.0] GOTCHA v1.0.7, Check v0.15.2 #21399
Conversation
Test report by @Thyre |
87bf02b
to
9325871
Compare
Test report by @Thyre |
9325871
to
b95b111
Compare
@boegelbot: please test @ generoso |
@smoors: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2349757033 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Interesting. This looks like linking the downloaded library for the tests failed. Since parallel also causes issues with the tests, disabling the tests might be worth it... |
Test report by @smoors |
Signed-off-by: Jan André Reuter <[email protected]>
b95b111
to
8141a3f
Compare
Signed-off-by: Jan André Reuter <[email protected]>
8141a3f
to
5fefc6d
Compare
Test report by @Thyre |
Switched to Check in EasyBuild (added EasyConfig for GCCcore/13.3.0). This should hopefully solve the issues. |
Test report by @SebastianAchilles |
@boegelbot please test @ jsc-zen3 |
@SebastianAchilles: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2350958780 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ generoso |
@SebastianAchilles: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2350959862 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @Thyre! |
Add GOTCHA, a library which helps to wrap function calls. This will get relevant for tools like Score-P.
The build itself is straight-forward, but parallel builds need to be disabled due to issues when enabling tests.
This is not a huge problem though, as the library builds quickly (~20 seconds on my machine).