-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{math}[foss/2023a] rustworkx v0.12.1 #21354
{math}[foss/2023a] rustworkx v0.12.1 #21354
Conversation
Test report by @lcniel |
Not sure what's going on with the checksum issue, it seems like things are being double-counted between crates and sources? Is the easyblock here obsolete? I only built this as a dependency of #21353 |
The May be a side-effect of the changes in easybuilders/easybuild-easyblocks#3406? |
Or it's because of the changes in #21143, that's perhaps more likely |
@boegelbot please test @ generoso |
…asyconfigs into 20240909111016_new_pr_rustworkx0121
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2346563841 processed Message to humans: this is just bookkeeping information for me, |
Actually, the changes in #21143 probably fix the problem in the tests here (that PR was merged after this one was opened), so I think all this needs is a sync with current |
@boegelbot please test @ jsc-zen3 |
Test report by @boegelbot |
Test report by @boegel |
Still seeing this, so nope:
@Flamefire can maybe shed some light on this... |
Same problem in: |
I discussed this with @Micket earlier this week, he came to some conclusion and would look into it. |
This shouldn't happen. E.g. I added a copy operation in the checksum step to avoid it modifying the original EC instances. So it seems some other test is also modifying it and needs similar logic. I'm working on it. |
…asyconfigs into 20240909111016_new_pr_rustworkx0121
Problem with incorrect counting of checksums vs sources + patches is fixed in easybuilders/easybuild-easyblocks#3448 That creates another problem with verifying the checksums for patch files which makes the CI fail for |
…asyconfigs into 20240909111016_new_pr_rustworkx0121
@boegelbot please test @ jsc-zen3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2354798231 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Going in, thanks @lcniel! |
(created using
eb --new-pr
)