Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{math}[foss/2023a] rustworkx v0.12.1 #21354

Merged

Conversation

lcniel
Copy link
Contributor

@lcniel lcniel commented Sep 9, 2024

(created using eb --new-pr)

@lcniel
Copy link
Contributor Author

lcniel commented Sep 9, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis4-28 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, 1 x NVIDIA NVIDIA A100-SXM4-40GB, 545.23.08, Python 3.6.8
See https://gist.github.com/lcniel/73808b4bb4919a8faae6fafa73148710 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Sep 9, 2024

Not sure what's going on with the checksum issue, it seems like things are being double-counted between crates and sources? Is the easyblock here obsolete? I only built this as a dependency of #21353

@boegel
Copy link
Member

boegel commented Sep 12, 2024

The CargoPythonPackage easyblock is definitely not obsolete.

May be a side-effect of the changes in easybuilders/easybuild-easyblocks#3406?

@boegel
Copy link
Member

boegel commented Sep 12, 2024

Or it's because of the changes in #21143, that's perhaps more likely

@boegel boegel added the update label Sep 12, 2024
@boegel boegel added this to the 4.x milestone Sep 12, 2024
@boegel
Copy link
Member

boegel commented Sep 12, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21354 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21354 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14250

Test results coming soon (I hope)...

- notification for comment with ID 2346563841 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Sep 12, 2024

Actually, the changes in #21143 probably fix the problem in the tests here (that PR was merged after this one was opened), so I think all this needs is a sync with current develop... Did just that, let's see if CI agrees

@boegel
Copy link
Member

boegel commented Sep 12, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d51172bf6c90380fd38da7f028b894b5 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 12, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3128.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/b8287798451f1c023832e43b6e6be3cf for a full test report.

@boegel
Copy link
Member

boegel commented Sep 12, 2024

Actually, the changes in #21143 probably fix the problem in the tests here (that PR was merged after this one was opened), so I think all this needs is a sync with current develop... Did just that, let's see if CI agrees

Still seeing this, so nope:

Checksums missing for one or more sources/patches in rustworkx-0.12.1-foss-2023a.eb: found 137 sources + 0 patches vs 69 checksums

@Flamefire can maybe shed some light on this...

@boegel
Copy link
Member

boegel commented Sep 12, 2024

@lcniel
Copy link
Contributor Author

lcniel commented Sep 13, 2024

Actually, the changes in #21143 probably fix the problem in the tests here (that PR was merged after this one was opened), so I think all this needs is a sync with current develop... Did just that, let's see if CI agrees

Still seeing this, so nope:

Checksums missing for one or more sources/patches in rustworkx-0.12.1-foss-2023a.eb: found 137 sources + 0 patches vs 69 checksums

@Flamefire can maybe shed some light on this...

I discussed this with @Micket earlier this week, he came to some conclusion and would look into it.

@Flamefire
Copy link
Contributor

This shouldn't happen. E.g. I added a copy operation in the checksum step to avoid it modifying the original EC instances. So it seems some other test is also modifying it and needs similar logic. I'm working on it.

@boegel
Copy link
Member

boegel commented Sep 16, 2024

Problem with incorrect counting of checksums vs sources + patches is fixed in easybuilders/easybuild-easyblocks#3448

That creates another problem with verifying the checksums for patch files which makes the CI fail for DeltaLake-0.15.1-gfbf-2023a.eb, which should be fixed with #21416 #21419

@boegel
Copy link
Member

boegel commented Sep 17, 2024

@boegelbot please test @ jsc-zen3

@boegel boegel modified the milestones: 4.x, release after 4.9.3 Sep 17, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21354 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21354 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4885

Test results coming soon (I hope)...

- notification for comment with ID 2354798231 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/75a43435872af66d0558304161461e96 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 17, 2024

Going in, thanks @lcniel!

@boegel boegel merged commit b89bb92 into easybuilders:develop Sep 17, 2024
9 checks passed
@boegel boegel modified the milestones: release after 4.9.4, 4.9.4 Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants