Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Python easyblock to move sitecustomize.py into site-packages #3514

Merged
merged 5 commits into from
Dec 18, 2024
Merged

update Python easyblock to move sitecustomize.py into site-packages #3514

merged 5 commits into from
Dec 18, 2024

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Nov 22, 2024

fixes #3493

@Micket Micket added the change label Nov 22, 2024
@Micket Micket added this to the 5.0 milestone Nov 22, 2024
Flamefire
Flamefire suggested changes Nov 25, 2024
View reviewed changes
easybuild/easyblocks/p/python.py Outdated Show resolved Hide resolved
easybuild/easyblocks/p/python.py Outdated Show resolved Hide resolved
@Flamefire Flamefire mentioned this pull request Nov 25, 2024
Closed
@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Dec 3, 2024
@boegel boegel changed the title Move sitecustomize.py into site-packages update Python easyblock to move sitecustomize.py into site-packages Dec 3, 2024
@Micket
Remove backwards compat for module only rebuilds.
f536db3 
Also uses property to clean up small code duplication
@Micket
Drop unused imports
51b25e5
boegel
boegel approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor Author

Micket commented Dec 18, 2024

test report incoming

@Micket
Copy link
Contributor Author

Micket commented Dec 18, 2024

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS Python-3.12.3-GCCcore-13.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/b9db4475a3b4583d875cff9cb9d2367d for a full test report.

@boegel
Copy link
Member

boegel commented Dec 18, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Python-3.11.5-GCCcore-13.2.0.eb
  • SUCCESS Python-3.12.3-GCCcore-13.3.0.eb
  • SUCCESS tqdm-4.66.5-GCCcore-13.3.0.eb
  • SUCCESS PyYAML-6.0.2-GCCcore-13.3.0.eb
  • SUCCESS scikit-learn-1.4.0-gfbf-2023b.eb
  • SUCCESS matplotlib-3.8.2-gfbf-2023b.eb
  • SUCCESS Seaborn-0.13.2-gfbf-2023b.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3569.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/boegel/965275cbf6e6f79c5753413df27be745 for a full test report.

@boegel boegel merged commit ca29703 into easybuilders:5.0.x Dec 18, 2024
19 checks passed
@boegel boegel mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flamefire Flamefire Flamefire requested changes

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Micket @boegel @Flamefire