adopt module_load_environment: Bundle

[lexming]

Update of Bundle easyblock for #3527

Also fixes issue #3528

[boegel]

@lexming I suspect that #3509 will get merged soon, which will cause trouble/conflicts here.

Maybe we can revert the changes to the Bundle easyblock made here for now, and postpone that to another PR to avoid a complex conflict resolution situation?

[Thyre]

@lexming I suspect that #3509 will get merged soon, which will cause trouble/conflicts here.

Maybe we can revert the changes to the Bundle easyblock made here for now, and postpone that to another PR to avoid a complex conflict resolution situation?

I think that this should not cause a merge conflict. #3509 doesn't touch the lines changed by this PR and comp, used by this PR, is still defined.
However, having both module_load_environment and make_module_req_guess in the same EasyBlock is probably not a good idea.

I think there are two options:

• We can move the changes in Bundle to a separate PR
• Update this PR if enhance generic Bundle easyblock to transfer module requirements of components, but do not create logfile in components #3509 is merged before this one.

[lexming]

Having both module_load_environment and make_module_req_guess is indeed undesirable. I propose that #3509 gets merged first and then I'll update this PR to adapt those changes to the new approach.

I changed the scope of this PR to only concern Bundle.

[boegel]

@lexming I think this PR should only get merged if all other easyblocks have been updated to use module_load_environment rather than customizing make_module_req_guess, since with the changes made here customized make_module_req_guess methods for components will be ignored?