Reset translation in test tearDown #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasmohrin
requested changes
Oct 14, 2024
richardebeling
force-pushed
the
flaky-tests-translations
branch
2 times, most recently
from
6079b54 to
0758cb5
Compare
Kakadus
approved these changes
Oct 14, 2024
|
The second failure with seed 7524442357 still breaks on my machine, now even with two tests failing. Maybe we can use https://github.com/asottile/detect-test-pollution ? |
richardebeling
force-pushed
the
flaky-tests-translations
branch
from
0758cb5 to
2b94bff
Compare
The problem was that |
niklasmohrin
approved these changes
Oct 21, 2024
|
output of evap/staff/tests/test_views.py
2379: def tearDown(self):
evap/evaluation/tests/tools.py
33: def tearDown(self):
evap/grades/tests.py
54: def tearDown(self):only |
|
Another seed fixed by this PR 1773734012 :) |
The TestCase tearDown implementation doesn't call super, so we need to inherit form the Mixin first (since MRO is not followed further after first match)
richardebeling
force-pushed
the
flaky-tests-translations
branch
from
a7bc317 to
84a0ce0
Compare
jooooosef
pushed a commit
to jooooosef/EvaP
that referenced
this pull request
Dec 16, 2024
* Reset translation in test tearDown to fix flakiness The TestCase tearDown implementation doesn't call super, so we need to inherit form the Mixin first (since MRO is not followed further after first match) * Call super.tearDown() in derived classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes order-dependent tests (as caused failure in https://github.com/e-valuation/EvaP/actions/runs/11331145512/job/31510516990)