Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use click handlers instead of inserting anchor tags in .table-seamless-links #2117

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Use click handlers instead of inserting anchor tags in .table-seamless-links #2117

merged 1 commit into from
Feb 22, 2024

Conversation

niklasmohrin
Copy link
Member

@niklasmohrin niklasmohrin commented Feb 12, 2024 •
edited
Loading

This way we don't need to think about the DOM elements being moved around and we can stop click events in nested elements.

This came up in #1985

@niklasmohrin
Use click handlers instead of inserting anchor tags in `.table-seamle…
1e3090b 
…ss-links`

This way we don't need to think about the DOM elements being moved
around and we can stop click events in nested elements.
richardebeling
richardebeling approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine, works nicely in Firefox 121 on Ubuntu

Kakadus
Kakadus approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@Kakadus Kakadus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good on firefox 122.0.1 😄

@niklasmohrin niklasmohrin merged commit 21bd711 into e-valuation:main Feb 22, 2024
12 checks passed
@niklasmohrin niklasmohrin deleted the no-a branch February 22, 2024 17:29
@niklasmohrin
Copy link
Member Author

Working on #1985, I noticed that this breaks the delegation modal on the contributor index: Although the onclick= uses return false at the end, the click handler on the row is still run. In that PR, I changed the onclick= to addEventListener with event.stopPropagation

@niklasmohrin niklasmohrin mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kakadus Kakadus Kakadus approved these changes

@richardebeling richardebeling richardebeling approved these changes

@janno42 janno42 Awaiting requested review from janno42

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasmohrin @richardebeling @Kakadus