Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use translate and blocktranslate template tags #2114

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

richardebeling
Copy link
Member

They were introduced in django3.1 and, while it says the old tags are still supported, the documentation does not mention them anymore.

Replacement was done using the commands in the commit messages. I quickly looked through the results and they seem meaningful to me. It should be easy to rebase/redo, so we can wait (e.g. for #1985)

@richardebeling richardebeling merged commit f8776b2 into e-valuation:main Feb 26, 2024
12 checks passed
@richardebeling richardebeling deleted the translate-tag branch February 26, 2024 20:33
@niklasmohrin
Copy link
Member

I wonder if we should introduce a Github action workflow that greps for {% trans and {% blocktrans to ensure we only use the verbose names. What do you think?

@richardebeling
Copy link
Member Author

I wonder if we should introduce a Github action workflow that greps for {% trans and {% blocktrans to ensure we only use the verbose names. What do you think?

IMO it's not worth the effort now since we don't have the infrastructure. It doesn't really hurt if the old tags creep in, we can just replace any that we come by.

If we ever setup template linting / semgrep / whatever, I'd be fine with adding a rule for this, but I'd regard other stuff they check for as more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants