Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest user merge if user with same email address exists #2065

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

hansegucker
Copy link
Collaborator

Close #1958

evap/staff/forms.py Outdated Show resolved Hide resolved
evap/staff/templates/staff_user_form.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_user_form.html Outdated Show resolved Hide resolved
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Meets requirements
✔️ UI functionality checked

evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
@hansegucker
Copy link
Collaborator Author

@richardebeling Please review again.

evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(lgtm, once the other comment is fixed)

@niklasmohrin niklasmohrin merged commit ec9a65f into e-valuation:main Nov 13, 2023
12 checks passed
@richardebeling
Copy link
Member

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Suggest user merge if email address already exists
4 participants