Type hints for class based views (and other tools) #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
force-pushed
the
class-views-typing
branch
from
92d4446 to
1477182
Compare
richardebeling
force-pushed
the
class-views-typing
branch
from
1477182 to
2606654
Compare
richardebeling
force-pushed
the
class-views-typing
branch
from
2606654 to
78037b7
Compare
niklasmohrin
requested changes
Nov 13, 2023
| return not any(email.endswith("@" + domain) for domain in settings.INSTITUTION_EMAIL_DOMAINS) | ||
|
|
||
|
|
||
| def sort_formset(request, formset): | ||
| def sort_formset(request: HttpRequest, formset: BaseFormSet) -> None: | ||
| if request.POST: # if not, there will be no cleaned_data and the models should already be sorted anyways | ||
| formset.is_valid() # make sure all forms have cleaned_data |
There was a problem hiding this comment.
(not yours), but?
Suggested change
| formset.is_valid() # make sure all forms have cleaned_data | |
| assert formset.is_valid() # make sure all forms have cleaned_data |
There was a problem hiding this comment.
One test fails then. The method seems to be intended to also be callable with invalid formsets (via the default value in the line below).
niklasmohrin
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2055