Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ruff to ci #2051

Merged
merged 61 commits into from
Apr 8, 2024
Merged

Introduce ruff to ci #2051

merged 61 commits into from
Apr 8, 2024

Conversation

Kakadus
Copy link
Collaborator

@Kakadus Kakadus commented Oct 23, 2023

No description provided.

@richardebeling richardebeling mentioned this pull request Oct 23, 2023
Closed
@Kakadus Kakadus force-pushed the ruff branch 5 times, most recently from 323c3f6 to 8162da3 Compare October 23, 2023 20:38
@Kakadus Kakadus changed the title New ruff New ruff first draft Oct 23, 2023
@Kakadus Kakadus marked this pull request as draft October 23, 2023 22:44
richardebeling
richardebeling reviewed Oct 25, 2023
View reviewed changes
evap/locale/de/formats.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
richardebeling
richardebeling reviewed Oct 30, 2023
View reviewed changes
test.py Outdated Show resolved Hide resolved
This was referenced Nov 6, 2023
Merged
Merged
@Kakadus Kakadus force-pushed the ruff branch 4 times, most recently from 0c4a603 to 8efe8ce Compare November 13, 2023 18:04
@Kakadus
Copy link
Collaborator Author

Kakadus commented Nov 13, 2023

rebased and cleaned the commits a bit. #2063 and #2064 are no longer part of this

@Kakadus Kakadus force-pushed the ruff branch 6 times, most recently from 0841d75 to f51d297 Compare November 20, 2023 17:14
richardebeling
richardebeling reviewed Feb 5, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
richardebeling
richardebeling approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks :)

@Kakadus Kakadus requested a review from niklasmohrin March 4, 2024 20:03
niklasmohrin
niklasmohrin approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The switch from rule names to numbers for noqa and the explicit __all__ is a bit sad, but maybe ruff will figure it out in the future. Overall very nice!

evap/results/exporters.py Show resolved Hide resolved
@Kakadus Kakadus merged commit 90702c3 into e-valuation:main Apr 8, 2024
10 checks passed
@Kakadus Kakadus deleted the ruff branch April 8, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin approved these changes

@richardebeling richardebeling richardebeling approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kakadus @richardebeling @niklasmohrin