Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace toggle_no_grades with an idempotent alternative #2040

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Replace toggle_no_grades with an idempotent alternative #2040

merged 5 commits into from
Oct 23, 2023

Conversation

till2
Copy link
Collaborator

@till2 till2 commented Oct 16, 2023

Fixes #1965

till2 and others added 2 commits October 16, 2023 21:57
@till2 @LinqLover @constantin-kuehne
Replace toggle_no_grades with an idempotent alternative
cf2ff36 
Fixes e-valuation#1965

Co-Authored-By: Christoph Thiede <[email protected]>
Co-Authored-By: Constantin Kühne <[email protected]>
@till2 @LinqLover @constantin-kuehne
Fix formatting
a7afa5b 
Co-Authored-By: Christoph Thiede <[email protected]>
Co-Authored-By: Constantin Kühne <[email protected]>
@LinqLover LinqLover mentioned this pull request Oct 23, 2023
Merged
@LinqLover
Copy link
Collaborator

Please see till2#1.

richardebeling
richardebeling approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@richardebeling richardebeling merged commit 29b70ce into e-valuation:main Oct 23, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinqLover LinqLover LinqLover left review comments

@niklasmohrin niklasmohrin niklasmohrin approved these changes

@richardebeling richardebeling richardebeling approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace toggle_no_grades with an idempotent alternative
4 participants
@till2 @LinqLover @richardebeling @niklasmohrin