fix arrow alignment #2037
fix arrow alignment #2037
Conversation
| @@ -155,7 +155,7 @@ | |||
| } | |||
|
|
|||
| th.col-order { | |||
| padding-left: 1.4em; | |||
| padding-left: 1.4em !important; | |||
There was a problem hiding this comment.
@richardebeling This is now the same as in the rule for just .col-order, so we should be able to just remove this rule altogether, right? I am not sure why exactly we had explicitly different values for the th and non-th rules, maybe @janno42 can remember?
There was a problem hiding this comment.
we probably needed th.col-order to be more specific than something else to avoid using !important. removing this line would require us to put !important behind the rule in .col-order.
i would prefer a solution without !important by adding the other classes of the object to the selector for higher specificity (https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity)
There was a problem hiding this comment.
So the steps for the authors are then:
- Get a rough understanding of specificity
- Find clashing selector (the one that is currebtly overwriting our rule; you can find it in the browser's inspector)
- Find more specific selector than that
- Investigate how we can have the padding value not duplicated, but only written once in the file
... and ask for help at any step and take your time to understand everything as thoroughly as you want :)
(Or, it is also possible that this plan fails because we forgot something, so reach out if something feels odd)
|
@jolanda19B Do you want to continue working on this or should we take over? |
fix #2033