Use bootstrap grid for staff evaluation #1889
Conversation
There was a problem hiding this comment.
The problem is that all rows, including the header, are sized independently. If the edit button column would have a header text, the layout would break. Also, if in some rows the button group would be smaller, the edit button would move to the right and also break the layout.
The current approach is probably not what we should use. Do you have any further ideas?
|
@janno42 Now its not a bootstrap grid anymore, but the "datagrid", which is also used for e.g. the grades semester view. It should allow for absolute / equal sizing of all columns. |
FranzSw
force-pushed
the
replace-textanswer-review-html-table
branch
from
9026978 to
909e4b4
Compare
| @@ -2,6 +2,11 @@ | |||
| background-color: $table-striped-bg; | |||
| } | |||
|
|
|||
| // CSS Grid needs it the exact other way around as the title also has the row class | |||
There was a problem hiding this comment.
are you missing a word here? this comment is hard to read.
There was a problem hiding this comment.
As discussed, we could move the padding (and other classes) into the scss, making it easier to work with the template. I pushed a suggestion, what do you think of it?
When testing, I noticed that the original textanswer after editing is not correctly placed. It should be under the new answer, not beside it. Can you please have a look into it?
|
@janno42 Original textanswer should now be shown below the new one :) |
- rename grid-row template to table-grid - move classes to scss - use border-bottom
This is the
"low-effort" versionhigh-effort approach, using bootstrap classes. This works well, however, aligning the columns to be the same size is not really possible with the default classes (atleast I didnt find the ones with the right width for this table). With dynamic sizing, this only shifts the second title "Entscheidung" to the right.Before:
After:
closes #1818