Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Initial implementation #2

Merged
merged 27 commits into from
Oct 26, 2022
Merged

PR: Initial implementation #2

merged 27 commits into from
Oct 26, 2022

Conversation

LuchoTurtle
Copy link
Member

This is the PR for the initial implementation of this tutorial and feature. So far it's still a work-in-progress and there are some features that I'd like to add such as:

  • different colors between cursors for each user
  • interaction between each user (below cursor)
  • fixing CSS overflow concerns.

@LuchoTurtle LuchoTurtle added enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. labels Oct 21, 2022
@LuchoTurtle LuchoTurtle self-assigned this Oct 21, 2022
@nelsonic nelsonic changed the title Initial implementation PR: Initial implementation Oct 24, 2022
@LuchoTurtle
Copy link
Member Author

@nelsonic here's the fully tested and with the README completed version of the project. Let me know if anything's missing 😄

@LuchoTurtle LuchoTurtle requested a review from nelsonic October 24, 2022 16:04
@nelsonic
Copy link
Member

@LuchoTurtle sorry I didn't get to this sooner. ⏳
Please assign PRs to me when ready else I don't get notified ... 👤
I know the UI/UX of GitHub is confusing with the "Request review" interface/action. 🙄
But given how many notifications I get per day, 📥
the only one I look at for "unblocking" or reviewing PRs is: github.com/pulls/assigned 🔔
I know it might feel like "process" (bordering on bureaucracy...),
but for us the in-progress label means "still being worked on by the assignee" 👨‍💻
whereas awaiting-review - no surprises - means "awaiting review of the person it's assigned to". 🙏
Our aim is to completely streamline these types of interactions in our App. 📱
GitHub is a bit of a Frankenstein's Monster when it comes to "workflow" ... 🤷‍♂️

Anyway, looking at this now. 👌

@nelsonic nelsonic assigned nelsonic and unassigned LuchoTurtle Oct 26, 2022
@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed technical A technical issue that requires understanding of the code, infrastructure or dependencies and removed in-progress An issue or pull request that is being worked on by the assigned person labels Oct 26, 2022
@nelsonic nelsonic added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Oct 26, 2022
@nelsonic
Copy link
Member

Dunno if you saw this while you were doing your pre-review: 💭

image

image

Going to take a look at resolving it now. 👨‍💻 ⏳

@nelsonic
Copy link
Member

Luckily someone else has seen this and took the time to open this ElixirForum Post:
https://elixirforum.com/t/liveview-session-was-misconfigured-or-the-user-token-is-outdated/32219/2
image

Simple fix. ✅

@nelsonic
Copy link
Member

Works well on localhost: 🎉

cursor-tracking-demo-GIF

Going to deploy to fly.io for live demo. 🤞

@nelsonic
Copy link
Member

https://live-cursors.fly.dev 🚀

@nelsonic
Copy link
Member

Enabled auto-deploys via ci.yml

@nelsonic nelsonic temporarily deployed to dwylauth October 26, 2022 07:33 Inactive
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@97213b9). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6ddce0f differs from pull request most recent head 769aa1d. Consider uploading reports for the commit 769aa1d to get more accurate results

@@           Coverage Diff            @@
##             main        #2   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         2           
  Lines           ?        22           
  Branches        ?         0           
========================================
  Hits            ?        22           
  Misses          ?         0           
  Partials        ?         0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nelsonic nelsonic temporarily deployed to dwylauth October 26, 2022 07:43 Inactive
@nelsonic nelsonic temporarily deployed to dwylauth October 26, 2022 08:06 Inactive
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle looks superb! Ship! :shipit:

@nelsonic nelsonic merged commit 0acf491 into main Oct 26, 2022
@nelsonic nelsonic deleted the initial-implementation branch October 26, 2022 08:07
@nelsonic
Copy link
Member

Next, Please see: dwyl/mvp#190 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement of existing functionality epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. in-review Issue or pull request that is currently being reviewed by the assigned person technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants