Tags Page with more details

[panoramix360]

This improves the Tags Page to have much more details on its table #396.

I moved some common methods between Stats <-> Tag to do the sorting on the Repo module, maybe we could create a new module for it, but let's see what you guys think.

Things missing

• Add tests for the new stuff
• Sorting the virtual columns Feat: Sort + Filter Tags Table Columns/Values using JS Lib #436

[nelsonic]

Dedicated issue for sorting/filtering: #436

[panoramix360]

hey @nelsonic and @LuchoTurtle!

Finally, I was able to test the files!

Can you guys review it?

Can you help me with this?

• I'm having trouble testing the tags_live, it seems that the creation of tags/items is not producing results on the tests, this is strange since the other live tests work fine. When I add tags to the DB it seems that it doesn't get added for the tests to work.
• I fixed the merge conflicts but I saw that you guys created some modifications regarding lists on the tags controller/view and this might need some work to the index live view of the tags.
• I notice that the test files are being ignored by the formatter on .formatter.exs, is this the intended behavior?

I'll wait for your answers!

Thank you and sorry to take a while to create tests for these.

[panoramix360]

@nelsonic

Forgot to mention that I saw that you commented some asserts on the stats_live tests and I fixed them! :D

[LuchoTurtle]

Thanks for the amazing work @panoramix360 <3
I'm testing this and everything seems to be working perfectly!

Running mix c locally also works without a hitch. I'll take a quick look over the code and approve it :)

[LuchoTurtle]

Other than my comment, I think this PR is just plain awesome 🥳.
I think the only thing missing is a simple write-up in the BUILDIT.md detailing the changes you've made in this PR. After that, we'll merge it instantly!

[panoramix360]

hey @nelsonic and @LuchoTurtle

I just created the new section on the docs with these modifications, but I'm unable to push the branch on this repo.

Should I fork it to add a pull request there? I think that I had the permissions earlier for this.

Please, let me know what I need to do, thanks!

[LuchoTurtle]

@panoramix360 🤔 you should be able to at least create a PR. If you can't, maybe forking and creating a PR will be faster.
If that's too much work, you can simply add the section you've written to this repo's BUILDIT.md, which also works :)

[panoramix360]

great!

it's here!

dwyl/book#100

[LuchoTurtle]

Thank you so much @panoramix360 !
Can you copy the text from https://github.com/dwyl/book/pull/100/files you've just created into the BUILDIT.md in this PR? Just for completeness :)
I'll approve it after you commit it.

Last stretch! 🏃 Thank you so, so much, again! 🙏

[panoramix360]

@LuchoTurtle, done!

[nelsonic]

Excellent Additions @panoramix360 thanks again. 🙏

[nelsonic]

"Merging can be performed automatically once the requested changes are addressed."

🤷‍♂️

[panoramix360]

Strange, the requested changes were already addressed

[nelsonic]

Yeah, all seem to be resolved. Might need to manual override to merge. 💭

[nelsonic]

I think it's because @LuchoTurtle requested the changes so it's "pending reviewer" ...

[nelsonic]

I'm going to manual override as @LuchoTurtle is busy. 👌