Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Allow creating new tag #208

Merged
merged 2 commits into from
Nov 22, 2022
Merged

PR: Allow creating new tag #208

merged 2 commits into from
Nov 22, 2022

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Nov 21, 2022 •
edited
Loading

Display form for creating new tags
ref: #201 (comment)

image

image

@SimonLab
Allow user to create new tag
da4289b 
Display form for creating new tags
@SimonLab SimonLab self-assigned this Nov 21, 2022
@SimonLab SimonLab temporarily deployed to dwylauth November 21, 2022 12:42 Inactive
@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022 •
edited
Loading

Codecov Report

Merging #208 (8d1fbe1) into main (8809718) will decrease coverage by 1.31%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              main     #208      +/-   ##
===========================================
- Coverage   100.00%   98.68%   -1.32%     
===========================================
  Files           13       13              
  Lines          221      228       +7     
===========================================
+ Hits           221      225       +4     
- Misses           0        3       +3
Impacted Files Coverage Δ
lib/app_web/controllers/tag_controller.ex 100.00% <100.00%> (ø)
lib/app_web/live/app_live.ex 96.10% <0.00%> (-3.90%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SimonLab
Add test for creating tags
8d1fbe1 
Add tests for post and new endpoint
@SimonLab SimonLab temporarily deployed to dwylauth November 21, 2022 13:05 Inactive
@SimonLab
Copy link
Member Author

coverage down on "project" linked to empty line:
image

@SimonLab SimonLab requested a review from nelsonic November 21, 2022 13:09
@SimonLab SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Nov 21, 2022
@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Nov 21, 2022
@nelsonic nelsonic changed the title Allow user to create new tag PR: Allow creating new tag Nov 21, 2022
@nelsonic nelsonic added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Nov 21, 2022
nelsonic
nelsonic approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good additions @SimonLab 👍

@nelsonic nelsonic merged commit daaa369 into main Nov 22, 2022
@nelsonic nelsonic deleted the create-tags branch November 22, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonLab @nelsonic