PR: Add tags to items #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `mix deps.udpate --all` ref: #245
SimonLab
added
the
in-progress
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 9 +2
Lines 136 166 +30
=========================================
+ Hits 136 166 +30
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Create Ecto migration with unique indexes for tags and items_tags ref: #245 app
Add schemas and use many_to_many function to create associations between tags and items
Link tag to a person
Add primary_key: false option in migration
Test the Tag schema see https://hexdocs.pm/phoenix/testing_contexts.html#testing-schemas
Create .iex.exs file with aliases. This allow us to access directly the aliases when running a `iex -S mix` session ref: https://twitter.com/mplatts/status/1570674202465935360
Add documentation on how to create the tags migrations and schemas
- Add more documentation about the migrations and schemas - use citext in migration
- Get the latest version of LiveView - assign_new is now part of Phoenix.Component module
Add simple test to test field value for ItemTag schema
Define name of the unique constraint. This will convert the raised error to changeset error
nelsonic
reviewed
Sep 26, 2022
lib/app/item.ex
Outdated
| @@ -48,7 +48,6 @@ defmodule App.Item do | |||
| def create_item_with_tags(attrs) do | |||
| %Item{} | |||
| |> changeset_with_tags(attrs) | |||
| |> IO.inspect() | |||
There was a problem hiding this comment.
worth updating the Elixir version to v1.14 so that we can use dbg? 😉 #finally 🎉
Display list of tags under each items Run formatter on project
Add link to tak to filter the list by tag
Add tests when filter by tag name
Finish documentation for items-tags association
|
Let me know your thoughts on this @nelsonic |
SimonLab
added
awaiting-review
nelsonic
added
in-review
nelsonic
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Tested on localhost:
git pull
git checkout 'tags-#245'
mix deps.udpate --all
Upgraded:
ecto 3.8.4 => 3.9.0
ecto_sql 3.8.3 => 3.9.0
phoenix_live_view 0.18.0 => 0.18.1
mix test
...
Finished in 1.1 seconds (0.2s async, 0.9s sync)
41 tests, 0 failures
Good sign. 👌
mix ecto.migrate
22:22:49.641 [info] == Running 20220915103524 App.Repo.Migrations.AddTags.change/0 forward
22:22:49.650 [info] execute "CREATE EXTENSION IF NOT EXISTS citext"
22:22:49.762 [info] create table tags
22:22:49.778 [info] create index tags_text_person_id_index
22:22:49.781 [info] == Migrated 20220915103524 in 0.1s
22:22:49.873 [info] == Running 20220915104854 App.Repo.Migrations.AddItemsTags.change/0 forward
22:22:49.873 [info] create table items_tags
22:22:49.880 [info] create index items_tags_item_id_tag_id_index
22:22:49.882 [info] == Migrated 20220915104854 in 0.0sMigrations appear to work.
mix phx.serverCreated a new item with tags. ✅
When I attempt to edit the item I am not able to edit the tags:
@SimonLab this is looking very good so far.
Quite happy to merge it so we can ship + test it and add more features later. 💭
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mix deps.udpate --allto make sure all is up to dateref: dwyl/app#245