Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Select input for tags #201

Closed
SimonLab opened this issue Nov 11, 2022 · 11 comments
Closed

Use Select input for tags #201

SimonLab opened this issue Nov 11, 2022 · 11 comments
Labels
awaiting-review An issue or pull request that needs to be reviewed discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality technical A technical issue that requires understanding of the code, infrastructure or dependencies user-feedback Feedback from people using the App

Comments

@SimonLab
Copy link
Member

Now that the select input example is ready: dwyl/learn-alpine.js#18

I'm trying to add it for adding tags:

image

I think I need to review the existing classes on the other element of the page to make sure we have the correct structure to add the select input without too many issues.

@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Nov 11, 2022
@SimonLab SimonLab self-assigned this Nov 11, 2022
@SimonLab SimonLab moved this to 🏗 In progress in dwyl app kanban Nov 11, 2022
@SimonLab
Copy link
Member Author

SimonLab commented Nov 11, 2022

At the moment tags are created directly with the input text. However adding the new select/dropdown doesnt' allow you to create on the fly new tags.

So we need to add a "new" button on the /tags endpoint to create new ones:
image

  • Add new tag button

@nelsonic
Copy link
Member

nelsonic commented Nov 11, 2022

These two screenshots are a reminder that our MVP needs some major UI TLC. 💭 #202

@SimonLab
Copy link
Member Author

Display list of tags:
image

Display selected tags:
image

Add "edit tags" link at the bottom of the list tags, useful when there aren't any tags:
image

The select input tags is working for the new item.
I want to see if I can change the code to a phoenix component that I can then reuse when editing the existing tasks

@SimonLab SimonLab removed the in-progress An issue or pull request that is being worked on by the assigned person label Nov 30, 2022
@nelsonic
Copy link
Member

@SimonLab, @iteles, @LuchoTurtle, @Stephanymtr & @seaneady 👋
Please let me know your thoughts on the following Tags Progressive UI/UX:

image

Direct link to Figma page: https://www.figma.com/file/WrpkKGJNYZbeCzMRDVtvQLbC/dwyl-app?node-id=246%3A2

@LuchoTurtle
Copy link
Member

Having read through Level 1 and Level 2, I found it quite enlightening and found no issue with the logic behind each decision, given it's meant to onboard the user into the app in their first "trial".

My only question is on Level 2. When the person starts typing an issue, the rest of the page is hidden, focusing solely on the save button and textfield. However, what happens if the person decides he wants to cancel the action and go back? Is he meant to delete all of the text to "go back" and see the navigation buttons? Does he click away from the keyboard?

I find that either option has its pros and cons. The first can be time-consuming but it has a "clear path". However, in the latter scenario, the user might click away by mistake and lose all the progress writing the item.

@nelsonic
Copy link
Member

@LuchoTurtle excellent question! 🎉 ❤️
This deserves it's own issue and a section in Figma for clarity. 👌
Please open the issue here on MVP or on App and I will try my best to address it this morning. 🙏

@LuchoTurtle
Copy link
Member

Created the issue dwyl/app#299

@nelsonic
Copy link
Member

@nelsonic
Copy link
Member

nelsonic commented Feb 6, 2023

@SimonLab please share your thought on the tags UI/UX outlined above. ⬆️ #201 (comment)

@nelsonic nelsonic moved this from 🏗 In progress to 🔖 Ready for Development in dwyl app kanban Feb 6, 2023
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality technical A technical issue that requires understanding of the code, infrastructure or dependencies user-feedback Feedback from people using the App discuss Share your constructive thoughts on how to make progress with this issue awaiting-review An issue or pull request that needs to be reviewed labels Feb 6, 2023
@nelsonic nelsonic moved this from 🔖 Ready for Development to ⏳Awaiting Review in dwyl app kanban Feb 6, 2023
@SimonLab
Copy link
Member Author

My current thought on progressive UI/UX for the app:

Otherewise a couple of question we need to test with the UI implementation in Flutter:

  • Can we add the tag text field and the save button next to each other without making these two widgets too small or squished? I think I tried previously on the mobile view of the mvp and it was getting difficult to read the labels name especially if they are long. It might be fine with the right font size and widget widths with Flutter
    image

  • Having the selected tags above the input (text field widget) solve the issue of not seeing the tags you have selected when they are behind the dropdown. However I'm wondering if having the text field pushed down each time a new line of tags is added will be annoying for the person selected the tags. It might not, to be tested.
    image

@SimonLab SimonLab removed their assignment Feb 14, 2023
@nelsonic
Copy link
Member

@SimonLab thanks for your feedback.
Yes, it might be "tight" to have the save button and tags.
Fairly certain we will be getting rid of the "Save" button soon though.
So let's just focus on tags in Flutter. 👌

@github-project-automation github-project-automation bot moved this from ⏳Awaiting Review to ✅ Done in dwyl app kanban Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality technical A technical issue that requires understanding of the code, infrastructure or dependencies user-feedback Feedback from people using the App
Projects
Status: Done
Development

No branches or pull requests

3 participants