Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: DRY/componentize app_live.html.heex #105

Open
1 task
nelsonic opened this issue Jul 16, 2022 · 3 comments
Open
1 task

CHORE: DRY/componentize app_live.html.heex #105

nelsonic opened this issue Jul 16, 2022 · 3 comments
Assignees
Labels
BLOCKED :fire: Core team's HIGHEST priority, blocking critical work chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T4h Time Estimate 4 Hours tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Jul 16, 2022

At present the lib/app_web/live/app_live.html.heex file has a few bits of repeated nearly identical code. 🙄
This was done in the interest of speed but is not very maintainable and requires lots of scrolling.

Todo

  • split out the various tags e.g. <form>, <button> and timer into reusable components.

Please see: https://hexdocs.pm/phoenix_live_view/Phoenix.LiveComponent.html
Note: please wait for #89 / #90 to be complete/merged before tackling this. 🙏 ⏳
And if you are undertaking this chore, please document all the steps with instructions in the README.md 📝

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! technical A technical issue that requires understanding of the code, infrastructure or dependencies T4h Time Estimate 4 Hours priority-3 Third priority. Considered "Nice to Have". Not urgent. chore a tedious but necessary task often paying technical debt labels Jul 16, 2022
@nelsonic nelsonic moved this to 🔖 Ready for Development in dwyl app kanban Nov 11, 2022
@SimonLab
Copy link
Member

Adding the select input for tags (see #209) and the edit timer (#196 ) make the heex file even longer and it becomes difficult to read, navigate and update.

I'm looking at this now as it has become a blocker for me to be add the select input tags when editing existing items

@SimonLab SimonLab added priority-3 Third priority. Considered "Nice to Have". Not urgent. and removed priority-3 Third priority. Considered "Nice to Have". Not urgent. labels Nov 24, 2022
@SimonLab SimonLab moved this from 🔖 Ready for Development to 🏗 In progress in dwyl app kanban Nov 24, 2022
@nelsonic nelsonic added priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished BLOCKED :fire: Core team's HIGHEST priority, blocking critical work tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written and removed priority-3 Third priority. Considered "Nice to Have". Not urgent. labels Nov 24, 2022
@nelsonic
Copy link
Member Author

@SimonLab thanks for taking a look at it. If possible, could you port what you learn back to one of the tutorials
e.g: https://github.com/dwyl/phoenix-liveview-todo-list-tutorial so the learning is easier to digest? 🙏

@SimonLab SimonLab moved this from 🏗 In progress to 📋 Backlog in dwyl app kanban Feb 14, 2023
@nelsonic
Copy link
Member Author

We recently extended the counter tutorial to include LiveView Components:
https://github.com/dwyl/phoenix-liveview-counter-tutorial#bonus-level-use-a-liveview-component-optional

Feel like this could be tackled now. 💭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED :fire: Core team's HIGHEST priority, blocking critical work chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T4h Time Estimate 4 Hours tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants
@nelsonic @SimonLab and others