Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving edit item to its own page? #214

Open
SimonLab opened this issue Nov 24, 2022 · 3 comments
Open

Moving edit item to its own page? #214

SimonLab opened this issue Nov 24, 2022 · 3 comments
Assignees
Labels
chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes. tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@SimonLab
Copy link
Member

With the addition of new features, the edit item content start to get big:
image

Also having all the code for editing the item on the same page as creating and listing items make it difficult to manage, see #105

I think it would make sense to display an "edit" link for each items on the list and managing all the edit on another endpoint/page.

Do you think this makes sense?

@SimonLab SimonLab added enhancement New feature or enhancement of existing functionality discuss Share your constructive thoughts on how to make progress with this issue labels Nov 24, 2022
@LuchoTurtle
Copy link
Member

Agreed 👍
I quickly realized this while testing and I wanted a way to delete timers as well. But it was merged just so we could get early feedback on it.
I can take this issue if @nelsonic agrees if it's a priority or not.

@nelsonic nelsonic added help wanted If you can help make progress with this issue, please comment! chore a tedious but necessary task often paying technical debt labels Nov 24, 2022
@nelsonic
Copy link
Member

@SimonLab thank you very much for opening this issue. 🙌
Totally agree that it looks cluttered especially when viewed on a Desktop. 🖥️ #202
Also 100% agree that the code is difficult to manage ... 😕
hence: #105 our oldest open issue. 🔥

I don't have anything against having a separate "edit" page for items. 📄
However, I will say that on the [Flutter] Mobile App I think taping on an item.text
should just expand the item "edit mode" to full-screen rather than transitioning to a separate page.

All of this is semantics because if we adopt an API-driven approach (which is what we need to do!),
then POST items/:cid/edit is what we need to focus on.

None of the UI/UX for our App is even close to being "set in stone",
so let's just figure out what makes sense now for MVP.

If we can use a transition to ease the change
from the "all items" view to the Edit item view, it will be good. 💭

Go for it. 👌

@nelsonic nelsonic added priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished priority-1 Highest priority issue. This is costing us money every minute that passes. technical A technical issue that requires understanding of the code, infrastructure or dependencies tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written and removed priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished labels Nov 25, 2022
@nelsonic nelsonic moved this to 🔖 Ready for Development in dwyl app kanban Nov 25, 2022
@SimonLab SimonLab mentioned this issue Nov 28, 2022
@nelsonic
Copy link
Member

nelsonic commented Feb 6, 2023

@SimonLab did you make progress with this shift? 🧑‍💻
Or can I spend some time defining it in Figma so that we're all clear? 💭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes. tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Status: 🔖 Ready for Development
Development

No branches or pull requests

4 participants
@nelsonic @SimonLab @LuchoTurtle and others