-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tpr/24-sort-words #35
base: master
Are you sure you want to change the base?
Conversation
dictmaker.js
Outdated
|
||
console.log('processing word list...'); | ||
|
||
var words = content.split('\n'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var words
does not appear to be used below ... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh! That'll teach me to code on Xmas.
Hi, |
@MysticMight : I'd recommend doing that. It has been 2 months, it appears there's no rush to act on this PR. At this point, I wash my hands. Merge, fork, delete -- I don't care. Best of luck. |
I acted on doug719's advice and sorted
words.txt
andwords_alpha.txt
using the unixsort
command.Sorting the json file is trickier, so I wrote a JS script (I don't know Python) to generate it based on
words_alpha.txt
; you are welcome to rewrite it in Python.I also updated all three zip files.