Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Workaround TLS fragmented records but keep invalid UTF check #33

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Nov 29, 2023

Task/Issue URL: https://app.asana.com/0/488551667048375/1206049262682135/f

Description

See asana.

Revert the workaround for TLS fragmentation but keep the UTF8 check for sni hostname

Steps to test this PR

  • from this branch, publish the library to maven local ie. ./gradlew clean assemble publishToMavenLocal
  • In the DDG android app apply the following path
Subject: [PATCH] Maven local use
---
Index: build.gradle
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/build.gradle b/build.gradle
--- a/build.gradle	(revision d11f7491d7ab4b27223fd352f83c26be403e79ed)
+++ b/build.gradle	(revision 3b1fe446b5d33e4d8a7f400137134ea0b5a797d7)
@@ -40,6 +40,7 @@
     repositories {
         google()
         mavenCentral()
+        mavenLocal()
     }
     configurations.all {
         resolutionStrategy.force 'org.objenesis:objenesis:2.6'
Index: versions.properties
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>ISO-8859-1
===================================================================
diff --git a/versions.properties b/versions.properties
--- a/versions.properties	(revision d11f7491d7ab4b27223fd352f83c26be403e79ed)
+++ b/versions.properties	(revision 3b1fe446b5d33e4d8a7f400137134ea0b5a797d7)
@@ -55,7 +55,7 @@
 
 version.com.android.installreferrer..installreferrer=2.2
 
-version.com.duckduckgo.netguard..netguard-android=1.6.0
+version.com.duckduckgo.netguard..netguard-android=1.7.0-SNAPSHOT
 
 version.com.duckduckgo.synccrypto..sync-crypto-android=0.3.0
 
  • build DDG app
  • AppTP smoke tests

@aitorvs
Copy link
Collaborator Author

aitorvs commented Nov 29, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@aitorvs aitorvs force-pushed the fix/aitor/revert_tls_frag branch from 478946d to c969a0a Compare November 29, 2023 12:15
@aitorvs aitorvs merged commit c3874fb into main Nov 29, 2023
1 check passed
@aitorvs aitorvs deleted the fix/aitor/revert_tls_frag branch November 29, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants