Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malware protection localization #3673

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1202406491309510/1208958530747144/f

Description:

  • Localize malicious site detection page, dashboard, native strings

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Validate updated localized strings are applied when running in different languages (System -> Settings -> Language & Region -> Applications -> DuckDuckGo (match icon color) -> choose language

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@not-a-rootkit not-a-rootkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from alex/malware-protection-pixels to main December 20, 2024 09:14
@mallexxx mallexxx merged commit f23b4de into main Dec 20, 2024
25 checks passed
@mallexxx mallexxx deleted the alex/malware-protection-localization branch December 20, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants