Sabrina/disable contextual onboarding #3666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/72649045549333/1207512172220035/f Tech Design URL: CC: **Description**: Update to BSK due to changes for iOS
…ng (#3634) Task/Issue URL: https://app.asana.com/0/1208613456171888/1208801514911205/f Tech Design URL: https://app.asana.com/0/481882893211075/1208730499188670/f CC: **Description**: **Optional E2E tests**: - [ ] Run PIR E2E tests Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this. **Steps to test this PR**: 1. <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f) --------- Co-authored-by: Bartek Waresiak <[email protected]>
Task/Issue URL: https://app.asana.com/0/1201037661562251/1208943073994046/f - Include `~/Library/Group\ Containers/*.com.duckduckgo.macos.browser.app-configuration.debug/*` path to clear by the `./clean-app.sh` script
Task/Issue URL: https://app.asana.com/0/481882893211075/1208033567421351/f BSK PR: duckduckgo/BrowserServicesKit#1099 - add .malware threat and special page types
Task/Issue URL: https://app.asana.com/0/1208114992212396/1208796999534221/f Tech Design URL: https://app.asana.com/0/481882893211075/1208773437150501/f **Description**: Includes the following changes: * Bumps BSK which includes changes [here]. (duckduckgo/BrowserServicesKit#1120) * Also forces casts `SubscriptionProduct` type to `Product` type, but only in debug menu code
Task/Issue URL: https://app.asana.com/0/69071770703008/1208936504720914/f Description: This change adds 2 new messages to track actions in the Privacy Stats widget and implements usage and debug pixels for Privacy Stats.
…3662) Task/Issue URL: https://app.asana.com/0/1201037661562251/1208963146868222/f Description: This is to maintain compatibility with old Xcode versions to run UI tests.
Task/Issue URL: https://app.asana.com/0/414235014887631/1208827075841585/f Description: Add 'locale' to report broken site params was merged in to https://github.com/duckduckgo/macos-browser/tree/release/1.118.0 in a BSK hotfix release. This PR updates BSK to latest to introduce this change on main.
Task/Issue URL: https://app.asana.com/0/1201621708115095/1208921971523524/f Description: This change fixes layout of BackgroundCategoryView to correctly align multi-line title labels with other grid items.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Tech Design URL:
CC:
Description:
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
1.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation