Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lottie to 4.4.3 #2868

Closed
wants to merge 1 commit into from

Conversation

alessandroboron
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1206329551987282/1207585576095796/f

Description:

Update Lottie to 4.4.3. This includes general bug fixes + Introducing privacy manifest in lottie-spm repo (4.4.2)

Steps to test this PR:

  1. Ensure the App compiles
  2. Smoke test Lottie animations and ensure they run fine.

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Jun 17, 2024
@alessandroboron alessandroboron removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Jun 17, 2024
@tomasstrba tomasstrba removed their request for review June 19, 2024 19:27
Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Jun 27, 2024
@alessandroboron
Copy link
Contributor Author

We decided to hold off on updating Lottie as it generated performance issues in the past. Although they moved the privacy manifest in the lottie-spm, the current version still parses validly the one in lottie-ios as stated in lottie-spm Privacy manifest PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant