Implement tab bar remote message #14720
Annotations
10 errors, 12 warnings, and 2 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x405324e20> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000579a940> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12e22a1d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000057988f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12cc4cac0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600005463860> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x11b71e6e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000179c000> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x405434910> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000057a6aa0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40be85d50> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000057b3700> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x11fbd7ef0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000179fc80> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1745b0a00> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001799e40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12ceb2cc0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000179f4f0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x11b745600> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000017fc630> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40529b990> should deallocate", "<DuckDuckGo_WebView: 0x13ffc77a0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x12cfff140> should deallocate", "<DuckDuckGo_WebView: 0x12ccb4dd0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40524e270> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001798210> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x402db9380> should deallocate", "<DuckDuckGo_WebView: 0x408786910> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x17151f920> should deallocate", "<DuckDuckGo_WebView: 0x1715204a0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4052cdd30> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000017a5a20> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4053dd460> should deallocate", "<DuckDuckGo_WebView: 0x4053dd6c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x12cf6a610> should deallocate", "<DuckDuckGo_WebView: 0x40a798a40> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x170abee10> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600001785080> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4053b5070> should deallocate", "<DuckDuckGo_WebView: 0x4053b5700> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40be197f0> should deallocate", "<DuckDuckGo_WebView: 0x40be98cd0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12e1a5e90> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600005405810> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x12e3b47e0> should deallocate", "<DuckDuckGo_WebView: 0x17456f560> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40beea180> should deallocate", "<DuckDuckGo_WebView: 0x40beeabe0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1745cef80> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000178f230> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40a7b9870> should deallocate", "<DuckDuckGo_WebView: 0x40a7b9d30> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x17110a980> should deallocate", "<DuckDuckGo_WebView: 0x17110b150> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40a7e9430> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600005452b50> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4028e3b10> should deallocate", "<DuckDuckGo_WebView: 0x4028e7a30> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4028f5ae0> should deallocate", "<DuckDuckGo_WebView: 0x1745f9b00> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40cc087c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000179f700> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4053d66c0> should deallocate", "<DuckDuckGo_WebView: 0x405321600> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1711414c0> should deallocate", "<DuckDuckGo_WebView: 0x171142140> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40dfd6a40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000057a8bb0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40df70ac0> should deallocate", "<DuckDuckGo_WebView: 0x40df28cd0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4028af690> should deallocate", "<DuckDuckGo_WebView: 0x4028aff60> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Upload failed unit tests xcresult
No files were found with the provided path: Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Run integration tests
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Loading