Implement tab bar remote message #14719
Annotations
10 errors, 12 warnings, and 7 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14db3b0d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000057b5a0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4097db8d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000046929f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17ff4d700> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000046e94a0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x13804f480> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000005582c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14868f460> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600004575e40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14dad51a0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000005469f0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x11deec760> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000455a3c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x406fa1200> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000054b390> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12d1ac770> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600000541600> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1380f2300> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000054f9c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x12ff68460> should deallocate", "<DuckDuckGo_WebView: 0x14df32c00> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40fbbfdc0> should deallocate", "<DuckDuckGo_WebView: 0x40fb28d50> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14df7ce00> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000054d290> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x149844c70> should deallocate", "<DuckDuckGo_WebView: 0x149845440> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x178a15e50> should deallocate", "<DuckDuckGo_WebView: 0x178a168c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14f1480e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000055d130> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x16b45e8e0> should deallocate", "<DuckDuckGo_WebView: 0x16b45f840> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x17ff90c80> should deallocate", "<DuckDuckGo_WebView: 0x17ff91320> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x13de51cc0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600000559c30> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x14da23800> should deallocate", "<DuckDuckGo_WebView: 0x14da1eff0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40fb08a40> should deallocate", "<DuckDuckGo_WebView: 0x40fb04930> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x406f26800> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000055b2e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x16b42c740> should deallocate", "<DuckDuckGo_WebView: 0x16b4d67c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40fb113a0> should deallocate", "<DuckDuckGo_WebView: 0x40fb11cf0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x148682450> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600004688f20> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40fb625f0> should deallocate", "<DuckDuckGo_WebView: 0x138166500> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x14f5a06d0> should deallocate", "<DuckDuckGo_WebView: 0x14f5a0d70> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14f0a0480> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000456a100> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x13deff1e0> should deallocate", "<DuckDuckGo_WebView: 0x17ff24550> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x178b25c50> should deallocate", "<DuckDuckGo_WebView: 0x14986fa40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14f542360> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000054d080> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x406f4b8e0> should deallocate", "<DuckDuckGo_WebView: 0x11de0cfe0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4100279e0> should deallocate", "<DuckDuckGo_WebView: 0x4100ba9c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x14b9a0b10> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000057d3f0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1498ec5f0> should deallocate", "<DuckDuckGo_WebView: 0x1498e0eb0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x41008ae80> should deallocate", "<DuckDuckGo_WebView: 0x41008b630> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Upload failed unit tests xcresult
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testFeatureDisabledAndPhishingDetection_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenNotDetected_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingNotDetected_tabIsNotMarkedPhishing
|
Loading