Implement tab bar remote message #14711
Annotations
10 errors, 12 warnings, and 7 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x156c90410> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000065535a0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40dfa17a0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000026865d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40bf3e990> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006552100> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40d5a8f50> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006696d60> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x16f70e8a0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000066961b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40bfc3da0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000066af9c0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x125de6c80> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000654e730> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1754c0260> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000257aec0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x175412060> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000026bf700> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x171574780> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006696890> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40f341530> should deallocate", "<DuckDuckGo_WebView: 0x1518f92c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x400cc26b0> should deallocate", "<DuckDuckGo_WebView: 0x400cf8ed0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x41089abf0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000254b180> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x174d8b750> should deallocate", "<DuckDuckGo_WebView: 0x174d921e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x174d5fef0> should deallocate", "<DuckDuckGo_WebView: 0x174dbb150> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40ef3b2c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000669eaa0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x41875d4f0> should deallocate", "<DuckDuckGo_WebView: 0x41086dbd0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x418775230> should deallocate", "<DuckDuckGo_WebView: 0x418775a00> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x156c87500> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000252a3c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1507523e0> should deallocate", "<DuckDuckGo_WebView: 0x17549c1e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40df76120> should deallocate", "<DuckDuckGo_WebView: 0x40df30c40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40ef90440> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000654c210> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40ff5d440> should deallocate", "<DuckDuckGo_WebView: 0x40ff5de30> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40efdd1f0> should deallocate", "<DuckDuckGo_WebView: 0x40ef0d2a0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40ff870e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600002579ef0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40ff934c0> should deallocate", "<DuckDuckGo_WebView: 0x40ff69eb0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4108eb7b0> should deallocate", "<DuckDuckGo_WebView: 0x4108eee30> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x171623080> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000268d600> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40d5e7a20> should deallocate", "<DuckDuckGo_WebView: 0x40d5e31a0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40ffcd840> should deallocate", "<DuckDuckGo_WebView: 0x40ffcdce0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x174deb7f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000268def0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40bfa7f70> should deallocate", "<DuckDuckGo_WebView: 0x16f79b9d0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x41800ec00> should deallocate", "<DuckDuckGo_WebView: 0x41800f450> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1716bd8b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000026bd340> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40ffc14d0> should deallocate", "<DuckDuckGo_WebView: 0x40ff51e00> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40f3ec7e0> should deallocate", "<DuckDuckGo_WebView: 0x40f3e2cb0> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Upload failed unit tests xcresult
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testFeatureDisabledAndPhishingDetection_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenNotDetected_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingNotDetected_tabIsNotMarkedPhishing
|
Loading